php - Saving data in mysql using dynamic field names -


i have mysql table storing company id, opening/closing hours days of week , status (closed/open). made form fields , updating function. looks this. works, believe can optimised. can suggest how?

form:

            <form role="form" method="post" action="" autocomplete="off">                 <div class="box-body">                     <div class="row">                         <div class="col-sm-3 text-bold"><div class="padd bg-gray-light">day</div></div>                         <div class="col-sm-3 text-bold"><div class="padd bg-gray-light">status</div></div>                         <div class="col-sm-3 text-bold"><div class="padd bg-gray-light">opening</div></div>                         <div class="col-sm-3 text-bold"><div class="padd bg-gray-light">closing</div></div>                     </div>                     <?php while ($h = dbarray($get_hours)) { ?>                     <input type="text" name="day" value="<?php echo $h['day_day']; ?>">                     <?php                     // form values                     if ($h['day_status'] == 1) {                         $status_o = "checked";                         $status_c = "";                     }                     if ($h['day_status'] == 0) {                         $status_o = "";                         $status_c = "checked";                     }                     ?>                     <div class="row">                         <div class="col-sm-3">                             <h4><?php echo $l['day_'.$h[day_day]]; ?></h4>                         </div>                         <div class="col-sm-3">                             <div class="input-group">                                 <div class="checkbox">                                     <label><input type="radio" name="status_<?php echo $h['day_day']; ?>" value="1" <?php echo $status_o; ?>> dirbame</label>                                     <label><input type="radio" name="status_<?php echo $h['day_day']; ?>" value="0" <?php echo $status_c; ?>> uždaryta</label>                                 </div>                             </div>                         </div>                         <div class="col-sm-3">                             <div class="form-group">                                 <input type="text" name="open_<?php echo $h['day_day']; ?>" class="form-control <?php if ($h['day_status'] == 0) { echo "bg-gray"; } ?>" value="<?php echo $h['day_open']; ?>">                             </div>                         </div>                         <div class="col-sm-3">                             <div class="form-group">                                 <input type="text" name="close_<?php echo $h['day_day']; ?>" class="form-control <?php if ($h['day_status'] == 0) { echo "bg-gray"; } ?>" value="<?php echo $h['day_close']; ?>">                             </div>                         </div>                     </div>                     <hr style="margin: 3px 0;">                     <?php } ?>                 </div>                  <div class="box-footer">                     <button type="submit" name="save" class="btn btn-success pull-right">save</button>                 </div>             </form> 

updating php:

<?php if (isset($_post['save'])) {     // values     $mon_status = stripinput(descript($_post['status_1'])); $mon_open = stripinput(descript($_post['open_1'])); $mon_close = stripinput(descript($_post['close_1']));     $tue_status = stripinput(descript($_post['status_2'])); $tue_open = stripinput(descript($_post['open_2'])); $tue_close = stripinput(descript($_post['close_2']));     $wed_status = stripinput(descript($_post['status_3'])); $wed_open = stripinput(descript($_post['open_3'])); $wed_close = stripinput(descript($_post['close_3']));     $thu_status = stripinput(descript($_post['status_4'])); $thu_open = stripinput(descript($_post['open_4'])); $thu_close = stripinput(descript($_post['close_4']));     $fri_status = stripinput(descript($_post['status_5'])); $fri_open = stripinput(descript($_post['open_5'])); $fri_close = stripinput(descript($_post['close_5']));     $sat_status = stripinput(descript($_post['status_6'])); $sat_open = stripinput(descript($_post['open_6'])); $sat_close = stripinput(descript($_post['close_6']));     $sun_status = stripinput(descript($_post['status_7'])); $sun_open = stripinput(descript($_post['open_7'])); $sun_close = stripinput(descript($_post['close_7']));     // update     $result1 = dbquery("update a_days set day_status='".$mon_status."', day_open='".$mon_open."', day_close='".$mon_close."' day_day=1");     $result2 = dbquery("update a_days set day_status='".$tue_status."', day_open='".$tue_open."', day_close='".$tue_close."' day_day=2");     $result3 = dbquery("update a_days set day_status='".$wed_status."', day_open='".$wed_open."', day_close='".$wed_close."' day_day=3");     $result4 = dbquery("update a_days set day_status='".$thu_status."', day_open='".$thu_open."', day_close='".$thu_close."' day_day=4");     $result5 = dbquery("update a_days set day_status='".$fri_status."', day_open='".$fri_open."', day_close='".$fri_close."' day_day=5");     $result6 = dbquery("update a_days set day_status='".$sat_status."', day_open='".$sat_open."', day_close='".$sat_close."' day_day=6");     $result7 = dbquery("update a_days set day_status='".$sun_status."', day_open='".$sun_open."', day_close='".$sun_close."' day_day=7"); } ?> 

loop on numeric suffixes of field names.

$results = array(); foreach (range(1, 7) $daynum) {     $status = stripinput(descript($_post['status_' . $daynum]));     $open = stripinput(descript($_post['open_' . $daynum]));     $close = stripinput(descript($_post['close_' . $daynum]));     $results[$daynum] = dbquery("update a_days set day_status='".$status."', day_open='".$open."', day_close='".$close."' day_day='.$daynum); } 

Comments